Updated top-of-file comments to include (c) 2017 The Bitcoin Developers
AbandonedPublic
Actions

Authored by CCulianu on Aug 11 2017, 17:14.

Details

Reviewers

freetrader
deadalnix

Group Reviewers

Restricted Project

Summary

It really bothered me that every file I open up has (c) The Core developers written on it. We are modifying this code too -- so we should put our copyright notices on each file as well. Why not? I apologize for the hugeness of this diff. I promise it's just top-of-file commends for each file in question and nothing more. It's possible that also the linter picked up some stuff too from files that it has never seen. If so -- sorry!

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

copyright_update

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 728
Build 728: arc lint + arc unit

Event Timeline

CCulianu created this revision.Aug 11 2017, 17:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 11 2017, 17:14

Oops.. a few files already had the (c) message so it was duplicated. Removed duplicates.

Harbormaster completed remote builds in B728: Diff 1165.Aug 11 2017, 17:28

I think we should only apply "our" copyright notices to files where we have made actual changes, not introduce a blanket claim on files with minimal changes (e.g. formatting only etc).
As developers we shouldn't be so lazy to not add/update it when we make changes to files.
Once in a while one can scan for modified files for which the copyright hasn't been added or updated correctly, and fix them.

This revision now requires changes to proceed.Aug 11 2017, 22:21

The bitcoin developers do not exclude core, it's good. Piling up junk in the header that need to be manually updated is a failure to leverage source control anyway.

@freetrader so you're decidedly against changing copyright notices to include us?

Well the thing is the MIT license allows people to create derivative works provided the original copyright notice appears alongside any new copyright notices. It's basically 'academic'-style credit. I wanted to add us so that if someone now creates a derivative work it's clear that their work is based off our sources which are based off core's which are based off Satoshi's, etc.

It was more out of respect for the license, and respect for all of our work going forward in the future that I decided to add these notices.

The notices already appear where it's important -- in the app gui, in the source repository, etc. But it would complete the cycle to also have them in all the source files, is all.

so you're decidedly against changing copyright notices to include us?

@CCulianu : please read what I wrote.

I'm against pasting "Bitcoin developers" copyright notices on files where we haven't made any meaningful changes so far.

I'm also firmly against removing "Bitcoin Core" and replacing it by just "Bitcoin developers" as deadalnix suggests. That would not be preserving correct attribution. It's not a "failure to leverage source control" either, it's just something that's not done. If the header at the top of the file bothers anyone, move them to the bottom, preserving attribution.

Ok, well, then I'll close this revision.

Large Diff

This large diff affects 399 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

Path

Size

src/

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

bench/

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

compat/

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

consensus/

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

crypto/

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

policy/

1 line

1 line

1 line

1 line

1 line

1 line

1 line

primitives/

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

qt/

addressbookpage.h

1 line

addressbookpage.cpp

1 line

addresstablemodel.h

1 line

addresstablemodel.cpp

1 line

askpassphrasedialog.h

1 line

askpassphrasedialog.cpp

1 line

bantablemodel.h

1 line

bantablemodel.cpp

1 line

bitcoin.cpp

1 line

bitcoinaddressvalidator.h

1 line

bitcoinaddressvalidator.cpp

1 line

bitcoinamountfield.h

1 line

bitcoinamountfield.cpp

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

coincontroldialog.cpp

1 line

coincontroltreewidget.h

1 line

coincontroltreewidget.cpp

1 line

csvmodelwriter.h

1 line

csvmodelwriter.cpp

1 line

editaddressdialog.h

1 line

editaddressdialog.cpp

1 line

1 line

1 line

1 line

1 line

1 line

1 line

macnotificationhandler.h

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

paymentrequestplus.cpp

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

qvalidatedlineedit.cpp

1 line

qvaluecombobox.h

1 line

qvaluecombobox.cpp

1 line

receivecoinsdialog.h

1 line

receivecoinsdialog.cpp

1 line

receiverequestdialog.h

1 line

receiverequestdialog.cpp

1 line

recentrequeststablemodel.h

1 line

recentrequeststablemodel.cpp

1 line

1 line

1 line

1 line

1 line

1 line

1 line

signverifymessagedialog.h

1 line

signverifymessagedialog.cpp

1 line

splashscreen.h

1 line

splashscreen.cpp

1 line

test/

1 line

1 line

1 line

1 line

paymentservertests.cpp

1 line

1 line

1 line

1 line

1 line

1 line

1 line

trafficgraphwidget.cpp

1 line

transactiondesc.h

1 line

transactiondesc.cpp

1 line

transactiondescdialog.h

1 line

transactiondescdialog.cpp

1 line

transactionfilterproxy.h

1 line

transactionfilterproxy.cpp

1 line

transactionrecord.h

1 line

transactionrecord.cpp

1 line

transactiontablemodel.h

1 line

transactiontablemodel.cpp

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

walletmodeltransaction.h

1 line

walletmodeltransaction.cpp

1 line

walletview.h

1 line

walletview.cpp

1 line

winshutdownmonitor.h

1 line

winshutdownmonitor.cpp

1 line

1 line

1 line

1 line

1 line

rpc/

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

script/

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

support/

allocators/

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

test/

1 line

1 line

1 line

1 line

arith_uint256_tests.cpp

1 line

1 line

1 line

1 line

1 line

1 line

blockencodings_tests.cpp

1 line

1 line

1 line

1 line

1 line

1 line

1 line

cuckoocache_tests.cpp

1 line

1 line

1 line

1 line

1 line

1 line

1 line

5 lines

1 line

1 line

1 line

1 line

1 line

1 line

policyestimator_tests.cpp

1 line

pow_tests.cpp

1 line

prevector_tests.cpp

1 line

raii_event_tests.cpp

1 line

reverselock_tests.cpp

1 line

rpc_tests.cpp

1 line

sanity_tests.cpp

1 line

scheduler_tests.cpp

1 line

script_P2SH_tests.cpp

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

test_bitcoin_fuzzy.cpp

1 line

1 line

1 line

1 line

1 line

transaction_tests.cpp

1 line

txvalidationcache_tests.cpp

1 line

uint256_tests.cpp

1 line

univalue_tests.cpp

1 line

util_tests.cpp

1 line

versionbits_tests.cpp

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

validationinterface.h

1 line

validationinterface.cpp

1 line

version.h

1 line

versionbits.h

1 line

versionbits.cpp

1 line

wallet/

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

test/

accounting_tests.cpp

1 line

crypto_tests.cpp

1 line

wallet_test_fixture.h

1 line

wallet_test_fixture.cpp

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

zmq/

zmqabstractnotifier.h

1 line

zmqabstractnotifier.cpp

1 line

zmqconfig.h

1 line

zmqnotificationinterface.h

1 line

zmqnotificationinterface.cpp

1 line

zmqpublishnotifier.h

1 line

zmqpublishnotifier.cpp

1 line

Updated top-of-file comments to include (c) 2017 The Bitcoin DevelopersAbandonedPublicActions

Details

Diff Detail

Event Timeline

Large Diff

Revision ContentsChangeset List

Diff 1165

src/addrdb.h

src/addrdb.cpp

src/addrman.h

src/addrman.cpp

src/amount.h

src/amount.cpp

src/arith_uint256.h

src/arith_uint256.cpp

src/base58.h

src/base58.cpp

src/bench/Examples.cpp

src/bench/base58.cpp

src/bench/bench.h

src/bench/bench.cpp

src/bench/bench_bitcoin.cpp

src/bench/ccoins_caching.cpp

src/bench/checkblock.cpp

src/bench/checkqueue.cpp

src/bench/coin_selection.cpp

src/bench/crypto_hash.cpp

src/bench/lockedpool.cpp

src/bench/mempool_eviction.cpp

src/bench/perf.h

src/bench/perf.cpp

src/bench/rollingbloom.cpp

src/bitcoin-cli.cpp

src/bitcoin-tx.cpp

src/bitcoind.cpp

src/blockencodings.h

src/blockencodings.cpp

src/bloom.h

src/bloom.cpp

src/chain.h

src/chain.cpp

src/chainparams.h

src/chainparams.cpp

src/chainparamsbase.h

src/chainparamsbase.cpp

src/checkpoints.h

src/checkpoints.cpp

src/checkqueue.h

src/clientversion.h

src/clientversion.cpp

src/coins.h

src/coins.cpp

src/compat.h

src/compat/byteswap.h

src/compat/endian.h

src/compat/glibc_compat.cpp

src/compat/glibc_sanity.cpp

src/compat/glibcxx_sanity.cpp

src/compat/sanity.h

src/compat/strnlen.cpp

src/compressor.h

src/compressor.cpp

src/consensus/consensus.h

src/consensus/merkle.h

src/consensus/merkle.cpp

src/consensus/params.h

src/consensus/validation.h

src/core_io.h

src/core_memusage.h

src/core_read.cpp

src/core_write.cpp

src/crypto/aes.h

src/crypto/aes.cpp

src/crypto/common.h

src/crypto/hmac_sha256.h

src/crypto/hmac_sha256.cpp

src/crypto/hmac_sha512.h

src/crypto/hmac_sha512.cpp

src/crypto/ripemd160.h

src/crypto/ripemd160.cpp

Updated top-of-file comments to include (c) 2017 The Bitcoin Developers
AbandonedPublic
Actions

Revision Contents
Changeset List