Page MenuHomePhabricator
Differential D4721

Fix enum NumConnections shadowing warning
ClosedPublic
Actions

Authored by Fabien on Dec 13 2019, 16:07.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGa5cd1ee1eb27: Fix enum NumConnections shadowing warning
rABCa5cd1ee1eb27: Fix enum NumConnections shadowing warning
Summary

Reduce the scope of the NumConnections enum in clientModel.cpp by
making it part of the ClientModel class.

This is an alternative to D4681.

Test Plan
ninja check

Check the -Wshadow warning no longer exist.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Dec 13 2019, 16:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 13 2019, 16:07
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Dec 13 2019, 16:07

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 13 2019, 16:17

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8548: Diff 14838.Dec 13 2019, 16:17
jasonbcox requested changes to this revision.Dec 13 2019, 21:18
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/qt/clientmodel.h
8 ↗(On Diff #14838)

Holdover from D4681? This doesn't look necessary anymore.

This revision now requires changes to proceed.Dec 13 2019, 21:18
Fabien requested review of this revision.Dec 14 2019, 08:42

D4681 is abandoned, this one use another approach and supersedes it.

deadalnix requested changes to this revision.Dec 16 2019, 14:16
deadalnix added inline comments.
src/qt/clientmodel.h
8 ↗(On Diff #14838)

Remove

This revision now requires changes to proceed.Dec 16 2019, 14:16
Fabien updated this revision to Diff 14868.Dec 16 2019, 15:48

Remove include.

teamcity added a comment.Dec 16 2019, 15:48

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 16 2019, 16:01

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8567: Diff 14868.Dec 16 2019, 16:01
jasonbcox accepted this revision.Dec 16 2019, 22:23
deadalnix accepted this revision.Dec 17 2019, 23:43
This revision is now accepted and ready to land.Dec 17 2019, 23:43
Closed by commit rABCa5cd1ee1eb27: Fix enum NumConnections shadowing warning (authored by Fabien). · Explain WhyDec 18 2019, 07:22
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCa5cd1ee1eb27: Fix enum NumConnections shadowing warning.
Fabien added a commit: rSTAGINGa5cd1ee1eb27: Fix enum NumConnections shadowing warning.Apr 7 2020, 22:08

Revision Contents
Changeset List

PathSize
src/
qt/
16 lines
2 lines
14 lines

Diff 14951

View Options

src/qt/clientmodel.h

Loading...
View Options

src/qt/clientmodel.cpp

Loading...
View Options

src/qt/rpcconsole.cpp

Loading...