Differential D4756

autoconf: Sane --enable-debug defaults.
ClosedPublic
Actions

Authored by Fabien on Dec 18 2019, 15:36.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING787cbc2d4b87: autoconf: Sane --enable-debug defaults.
rABC787cbc2d4b87: autoconf: Sane --enable-debug defaults.

Summary

Don't optimize at all when --enable-debug is supplied. This makes sure
that nothing is optimized out.

Backport of core PR16435:
https://github.com/bitcoin/bitcoin/pull/16435/files

Test Plan

cmake -GNinja -DCMAKE_BUILD_TYPE=Debug ..
ninja check

../configure --enable-debug
make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR16435

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8623
Build 15233: Default Diff Build & Tests
Build 15232: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 18 2019, 15:36

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 18 2019, 15:36

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8623: Diff 14964.Dec 18 2019, 15:46

Feel free to trash my ccache any time :)

This revision is now accepted and ready to land.Dec 18 2019, 17:13

It's debug only, your ccache is not completely lost !

Closed by commit rABC787cbc2d4b87: autoconf: Sane --enable-debug defaults. (authored by Carl Dong <contact@carldong.me>, committed by Fabien). · Explain WhyDec 18 2019, 20:05

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC787cbc2d4b87: autoconf: Sane --enable-debug defaults..

Fabien added a commit: rSTAGING787cbc2d4b87: autoconf: Sane --enable-debug defaults..Apr 7 2020, 22:08

Revision Contents
Changeset List

Path

Size

configure.ac

10 lines

src/

CMakeLists.txt

5 lines

Diff 14964

View Options

configure.ac

View Options

autoconf: Sane --enable-debug defaults.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 14964

configure.ac

src/CMakeLists.txt

autoconf: Sane --enable-debug defaults.
ClosedPublic
Actions

Revision Contents
Changeset List