Page MenuHomePhabricator

Remove blockprioritypercentage config parameter.
ClosedPublic

Authored by deadalnix on Dec 19 2019, 23:16.

Details

Summary

It's not tested and presumably not used at all. Nobody maintains it.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox added a subscriber: jasonbcox.

Over a year ago, it was mentioned that keeping this code around until we could fix up the block priority stuff might be useful. It's clear that the cost of maintaining this code is not worth keeping it around, so I'm happy to see this go. Maybe one day we can revisit the concept.

Reviewer note: This is similar in many ways to PR9602 which removes -blockprioritysize which was the original name of the argument before it was changed to -blockprioritypercentage in D485.

This revision is now accepted and ready to land.Dec 20 2019, 00:36

Ah I was going to do this but thanks :-) . I think there are still some priority leftovers after D4745 and this, but not much.