Page MenuHomePhabricator
Differential D4787

Do not log priority when using -printpriority
ClosedPublic
Actions

Authored by deadalnix on Dec 20 2019, 15:36.

Details

Reviewers
markblundeberg
Group Reviewers
Restricted Project
Commits
rSTAGING039d6f669c5a: Do not log priority when using -printpriority
rABC039d6f669c5a: Do not log priority when using -printpriority
Summary

Priority has no effect by now, it is time to cleanup.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
printdPriority
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8664
Build 15314: Default Diff Build & Tests
Build 15313: arc lint + arc unit

Event Timeline

deadalnix created this revision.Dec 20 2019, 15:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 20 2019, 15:36
teamcity added a comment.Dec 20 2019, 15:36

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 20 2019, 15:47

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8664: Diff 15029.Dec 20 2019, 15:47
deadalnix added a child revision: D4789: kill CTxMemPoolEntry::GetPriority.Dec 20 2019, 16:39
markblundeberg added a subscriber: markblundeberg.Dec 20 2019, 22:24

Apparently core still calls this option -printpriority even after PR9602, how odd...

markblundeberg accepted this revision.Dec 20 2019, 22:33
This revision is now accepted and ready to land.Dec 20 2019, 22:33
Closed by commit rABC039d6f669c5a: Do not log priority when using -printpriority (authored by deadalnix). · Explain WhyDec 20 2019, 22:53
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC039d6f669c5a: Do not log priority when using -printpriority.
markblundeberg mentioned this in D4812: finish backporting PR9602 : remove unused priority number in mempool mapDeltas.Dec 31 2019, 03:39
Mark Lundeberg <markblundeberg@users.noreply.github.com> mentioned this in rABCbe7332327629: finish backporting PR9602 : remove unused priority number in mempool mapDeltas.Jan 3 2020, 01:46
deadalnix added a commit: rSTAGING039d6f669c5a: Do not log priority when using -printpriority.Apr 7 2020, 22:12
Mark Lundeberg <markblundeberg@users.noreply.github.com> mentioned this in rSTAGINGbe7332327629: finish backporting PR9602 : remove unused priority number in mempool mapDeltas.Apr 7 2020, 22:15

Revision Contents
Changeset List

PathSize
src/
5 lines

Diff 15029

View Options

src/miner.cpp

Loading...