Paths

Table of Contentst

Differential D4799

[CMAKE] Separate the target for running the unit tests with upgrade
ClosedPublic
Actions

Authored by Fabien on Dec 23 2019, 20:17.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGINGd8745997e675: [CMAKE] Separate the target for running the unit tests with upgrade
rABCd8745997e675: [CMAKE] Separate the target for running the unit tests with upgrade

Summary

Add a new check-bitcoin-upgrade-activated target to run the unit tests
with the phonon activation time in the past (there is also a similar new
target for every boost unit tests suite).
This avoids having to reconfigure the build to run the tests.
Note that check-all runs this target as well for now.

Test Plan

ninja check-bitcoin # No upgrade
ninja check-bitcoin-upgrade-activated # With phonon activation
ninja check-all # Run both

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Dec 23 2019, 20:17

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 23 2019, 20:17

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien added a child revision: D4800: [CMAKE] Add a check-upgrade-activated magic target.Dec 23 2019, 20:21

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8684: Diff 15078.Dec 23 2019, 20:33

deadalnix accepted this revision.Dec 24 2019, 04:40

This revision is now accepted and ready to land.Dec 24 2019, 04:40

Closed by commit rABCd8745997e675: [CMAKE] Separate the target for running the unit tests with upgrade (authored by Fabien). · Explain WhyDec 24 2019, 09:12

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCd8745997e675: [CMAKE] Separate the target for running the unit tests with upgrade.

Fabien added a commit: rSTAGINGd8745997e675: [CMAKE] Separate the target for running the unit tests with upgrade.Apr 7 2020, 22:14

Revision Contents
Changeset List

Path

Size

cmake/

modules/

TestSuite.cmake

21 lines

src/

test/

CMakeLists.txt

2 lines

Diff 15083

View Options

cmake/modules/TestSuite.cmake