Page MenuHomePhabricator

depends macOS: point --sysroot to SDK
ClosedPublic

Authored by Fabien on Dec 31 2019, 12:47.

Details

Reviewers
deadalnix
rex4539
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING137cade69cd0: depends macOS: point --sysroot to SDK
rABC137cade69cd0: depends macOS: point --sysroot to SDK
Summary

point --sysroot to SDK in order to support building on macOS Catalina

Backport of core PR17118.

Test Plan

On macOS Catalina:

cd depends 
make build-osx NO_PROTOBUF=1 # building protobuf fails, needs investigation

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Owners added a reviewer: Restricted Owners Package.Dec 31 2019, 12:47
deadalnix requested changes to this revision.Jan 2 2020, 06:21

Can you point to the proper backport from Core?

This revision now requires changes to proceed.Jan 2 2020, 06:21

Please close this diff.

Apologies for wasting people's time.

Fabien added a reviewer: rex4539.
Fabien added a subscriber: Fabien.

Will revive

Fabien edited the test plan for this revision. (Show Details)
Fabien requested review of this revision.Apr 2 2020, 15:09

Requesting for review again.
This diff is useful for the native build of the OSX depends with Catalina (tested on 10.15.3).

This revision is now accepted and ready to land.Apr 2 2020, 16:38
This revision was automatically updated to reflect the committed changes.