Page MenuHomePhabricator
Differential D4816

depends macOS: point --sysroot to SDK
ClosedPublic
Actions

Authored by Fabien on Dec 31 2019, 12:47.

Details

Reviewers
deadalnix
rex4539
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING137cade69cd0: depends macOS: point --sysroot to SDK
rABC137cade69cd0: depends macOS: point --sysroot to SDK
Summary

point --sysroot to SDK in order to support building on macOS Catalina

Backport of core PR17118.

Test Plan

On macOS Catalina:

cd depends 
make build-osx NO_PROTOBUF=1 # building protobuf fails, needs investigation

Diff Detail

Repository
rABC Bitcoin ABC
Branch
catalina-fix (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8703
Build 15392: Default Diff Build & Tests
Build 15391: arc lint + arc unit

Event Timeline

rex4539 created this revision.Dec 31 2019, 12:47
Owners added a reviewer: Restricted Owners Package.Dec 31 2019, 12:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 31 2019, 12:47
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Dec 31 2019, 12:48

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 31 2019, 12:57

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8703: Diff 15099.Dec 31 2019, 12:57
deadalnix requested changes to this revision.Jan 2 2020, 06:21

Can you point to the proper backport from Core?

This revision now requires changes to proceed.Jan 2 2020, 06:21
rex4539 added a comment.Jan 2 2020, 06:24

https://github.com/bitcoin/bitcoin/pull/17118

rex4539 added a comment.Jan 3 2020, 16:25

Please close this diff.

Apologies for wasting people's time.

Fabien commandeered this revision.Apr 2 2020, 15:04
Fabien added a reviewer: rex4539.
Fabien added a subscriber: Fabien.

Will revive

Fabien edited the summary of this revision. (Show Details)Apr 2 2020, 15:06
Fabien edited the test plan for this revision. (Show Details)
Fabien requested review of this revision.Apr 2 2020, 15:09

Requesting for review again.
This diff is useful for the native build of the OSX depends with Catalina (tested on 10.15.3).

deadalnix accepted this revision.Apr 2 2020, 16:38
This revision is now accepted and ready to land.Apr 2 2020, 16:38
Closed by commit rABC137cade69cd0: depends macOS: point --sysroot to SDK (authored by rex4539, committed by Fabien). · Explain WhyApr 3 2020, 07:27
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC137cade69cd0: depends macOS: point --sysroot to SDK.
Fabien added a commit: rSTAGING137cade69cd0: depends macOS: point --sysroot to SDK.Apr 7 2020, 23:37

Revision Contents
Changeset List

PathSize
depends/
builders/
4 lines

Diff 15099

View Options

depends/builders/darwin.mk

Loading...