Page MenuHomePhabricator

Merge #14568: build: Fix Qt link order for Windows build
ClosedPublic

Authored by jasonbcox on Jan 3 2020, 19:59.

Details

Summary

fbaccbf00c build: Fix Qt link order for Windows build (Chun Kuan Lee)

Pull request description:

See https://github.com/bitcoin/bitcoin/pull/14451#issuecomment-432874893

Tree-SHA512: 819e68dc750297a74d04aa1ad3dae64072b66df718d36b950bd9430c9fca1771c611af934df23954f81b83bd89f96ea76c20cbf17db1364b988a6c34c43fb631

Backport of Core PR14568
https://github.com/bitcoin/bitcoin/pull/14568/files

Test Plan

Windows Gitian build on CI

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Snippet of first build failure:
lines=16,COUNTEREXAMPLE```[20:06:50] : [Step 1/1] (Reading database ... 70%
[20:06:50] : [Step 1/1] (Reading database ... 75%
[20:06:50] : [Step 1/1] (Reading database ... 80%
[20:06:50] : [Step 1/1] (Reading database ... 85%
[20:06:50] : [Step 1/1] (Reading database ... 90%
[20:06:50] : [Step 1/1] (Reading database ... 95%
[20:06:50] : [Step 1/1] (Reading database ... 100%
[20:06:50] : [Step 1/1] (Reading database ... 17687 files and directories currently installed.)
[20:06:50] : [Step 1/1] Removing rsyslog (8.1901.0-1) ...
[20:06:50] : [Step 1/1] invoke-rc.d: could not determine current runlevel
[20:06:50] : [Step 1/1] Stopping enhanced syslogd: rsyslogd already stopped.
[20:06:50] : [Step 1/1] (Reading database ...
[20:06:50] : [Step 1/1] (Reading database ... 5%
[20:06:50] : [Step 1/1] (Reading database ... 10%
[20:06:50] : [Step 1/1] (Reading database ... 15%
[20:06:50] : [Step 1/1] (Reading database ... 20%
[20:06:50] : [Step 1/1] (Reading database ... 25%
[20:06:50] : [Step 1/1] (Reading database ... 30%
[20:06:50] : [Step 1/1] (Reading database ... 35%
[20:06:50] : [Step 1/1] (Reading database ... 40%
[20:06:50] : [Step 1/1] (Reading database ... 45%
[20:06:50] : [Step 1/1] (Reading database ... 50%
[20:06:50] : [Step 1/1] (Reading database ... 55%
[20:06:50] : [Step 1/1] (Reading database ... 60%
[20:06:50] : [Step 1/1] (Reading database ... 65%
[20:06:50] : [Step 1/1] (Reading database ... 70%
[20:06:50] : [Step 1/1] (Reading database ... 75%
[20:06:50] : [Step 1/1] (Reading database ... 80%
[20:06:50] : [Step 1/1] (Reading database ... 85%
[20:06:50] : [Step 1/1] (Reading database ... 90%
[20:06:50] : [Step 1/1] (Reading database ... 95%
[20:06:50] : [Step 1/1] (Reading database ... 100%
[20:06:50] : [Step 1/1] (Reading database ... 17629 files and directories currently installed.)
[20:06:50] : [Step 1/1] Purging configuration files for rsyslog (8.1901.0-1) ...
[20:06:50] : [Step 1/1] Processing triggers for systemd (241-7~deb10u1) ...
[20:06:50] : [Step 1/1] Adding 'local diversion of /sbin/initctl to /sbin/initctl.distrib'
[20:06:50] : [Step 1/1] Adding 'local diversion of /usr/bin/ischroot to /usr/bin/ischroot.distrib'
[20:06:50]W: [Step 1/1] dpkg-divert: warning: diverting file '/usr/bin/ischroot' from an Essential package with rename is dangerous, use --no-rename
[20:06:50] : [Step 1/1] Adding 'local diversion of /usr/sbin/policy-rc.d to /usr/sbin/policy-rc.d.distrib'
[20:06:50] : [Step 1/1] Starting target
[20:06:51] : [Step 1/1] Checking if target is up
[20:06:51] : [Step 1/1] Preparing build environment
[20:06:54] : [Step 1/1] Updating apt-get repository (log in var/install.log)
[20:06:58] : [Step 1/1] Installing additional packages (log in var/install.log)
[20:07:53] : [Step 1/1] Upgrading system, may take a while (log in var/install.log)
[20:08:02] : [Step 1/1] Creating package manifest
[20:08:05] : [Step 1/1] Creating build script (var/build-script)
[20:08:07] : [Step 1/1] Running build script (log in var/build.log)
[20:10:33]W: [Step 1/1] ./bin/gbuild:21:in `system!': failed to run on-target setarch x86_64 bash -x < var/build-script > var/build.log 2>&1 (RuntimeError)
[20:10:33]W: [Step 1/1] from ./bin/gbuild:167:in `build_one_configuration'
[20:10:33]W: [Step 1/1] from ./bin/gbuild:318:in `block (2 levels) in <main>'
[20:10:33]W: [Step 1/1] from ./bin/gbuild:313:in `each'
[20:10:33]W: [Step 1/1] from ./bin/gbuild:313:in `block in <main>'
[20:10:33]W: [Step 1/1] from ./bin/gbuild:311:in `each'
[20:10:33]W: [Step 1/1] from ./bin/gbuild:311:in `<main>'
[20:10:33]W: [Step 1/1] ++ move_log
[20:10:33]W: [Step 1/1] ++ mv var/install.log /home/teamcity/buildAgent/work/c4a5708f2bae7929/gitian-results/
[20:10:33]W: [Step 1/1] ++ mv var/build.log /home/teamcity/buildAgent/work/c4a5708f2bae7929/gitian-results/
[20:10:33]W: [Step 1/1] Process exited with code 1
[20:10:33]E: [Step 1/1] Process exited with code 1 (Step: Command Line)

Added respective CMake changes

This revision is now accepted and ready to land.Jan 3 2020, 20:34