Page MenuHomePhabricator

Revert "[mining] Rename several CBlockTemplateEntry members for clarity"
ClosedPublic

Authored by markblundeberg on Jan 4 2020, 10:21.

Details

Summary

This reverts D2862 (commit cebcb34c93c05d42fbbe84d5f70cfadcb912e61f).
It seems it was part of a large stack that never went anywhere. Besides
that, the title was wrong as this was not rename-only: it added a
variable and changed type of sigops count from integer to unsigned.

This is a bit dangerous since negative sigops counts actually do get
passed in sometimes (as in one of the touched code lines), which means
they are converted to giant sigops count. This didn't actually cause
a bug but seems like an unintended effect for a rename-only diff.

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.