GUI: Change the receive button to respond to keypool state changing
ClosedPublic
Actions

Authored by deadalnix on Jan 6 2020, 13:46.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING97833b37ad0f: GUI: Change the receive button to respond to keypool state changing
rABC97833b37ad0f: GUI: Change the receive button to respond to keypool state changing

Summary

Check for more than private keys disabled to show receive button

Notify the GUI that the keypool has changed to set the receive button

Whenever the keypool changes (new keys generated, new seed set,
keypool runs out, etc.), notify the GUI that the keypool has changed. The
receive button can then be enabled and disabled as necessary.

This is a backport of Core PR15225

Test Plan

make check
./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr15225

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8750
Build 15484: Default Diff Build & Tests
Build 15483: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 6 2020, 13:46

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 6 2020, 13:46

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8750: Diff 15172.Jan 6 2020, 13:52

rebase

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8751: Diff 15175.Jan 6 2020, 14:24

Is there any way to test this without PR15226 ?

src/qt/walletmodel.cpp
436 ↗	(On Diff #15175)	Use `std::bind`

This revision now requires changes to proceed.Jan 6 2020, 16:17

deadalnix added inline comments.Jan 6 2020, 16:24

src/qt/walletmodel.cpp
436 ↗	(On Diff #15175)	It's boost bind in core still. Not sure if it matters.

Not sure about testing. PR15226 is indeed to next in my queue.

Use std::bind

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien accepted this revision.Jan 6 2020, 16:35

Fabien added inline comments.

src/qt/walletmodel.cpp
436 ↗	(On Diff #15175)	I just checked and you're right, it's still there... And it's the only occurrence in the codebase. That looks like a mistake to me, furthermore bind.hpp is never included.