Page MenuHomePhabricator

[CI] Disable crypto assembly when building with ASAN
ClosedPublic

Authored by Fabien on Tue, Jan 7, 13:54.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC1d0752d50148: [CI] Disable crypto assembly when building with ASAN
Summary

This is known to cause issue when the SHA256 SSE4 variant is selected.
This seems to be a long time open issue:
https://github.com/google/sanitizers/issues/192

This is expected to fix this kind of failures:
https://build.bitcoinabc.org/viewLog.html?tab=buildLog&logTab=tree&filter=debug&expand=all&buildId=25123&guest=1#footer

Test Plan

On a machine that does not support SHA-NI:

ABC_BUILD_NAME=build-asan ../contrib/teamcity/build-configurations.sh

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Tue, Jan 7, 13:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Jan 7, 13:54
deadalnix requested changes to this revision.Tue, Jan 7, 14:25

Add a comment in the code as to why this is disabled.

This revision now requires changes to proceed.Tue, Jan 7, 14:25
Fabien updated this revision to Diff 15193.Tue, Jan 7, 15:36

Add a comment explaining the issue.

deadalnix accepted this revision.Tue, Jan 7, 15:43
This revision is now accepted and ready to land.Tue, Jan 7, 15:43
This revision was automatically updated to reflect the committed changes.