Page MenuHomePhabricator
Differential D4842

[CI] Disable crypto assembly when building with ASAN
ClosedPublic
Actions

Authored by Fabien on Jan 7 2020, 13:54.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING1d0752d50148: [CI] Disable crypto assembly when building with ASAN
rABC1d0752d50148: [CI] Disable crypto assembly when building with ASAN
Summary

This is known to cause issue when the SHA256 SSE4 variant is selected.
This seems to be a long time open issue:
https://github.com/google/sanitizers/issues/192

This is expected to fix this kind of failures:
https://build.bitcoinabc.org/viewLog.html?tab=buildLog&logTab=tree&filter=debug&expand=all&buildId=25123&guest=1#footer

Test Plan

On a machine that does not support SHA-NI:

ABC_BUILD_NAME=build-asan ../contrib/teamcity/build-configurations.sh

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ci_asan_disable_asm
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8762
Build 15506: Default Diff Build & Tests
Build 15505: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 7 2020, 13:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 7 2020, 13:54
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jan 7 2020, 13:54

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 7 2020, 13:59

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8759: Diff 15190.Jan 7 2020, 13:59
deadalnix requested changes to this revision.Jan 7 2020, 14:25

Add a comment in the code as to why this is disabled.

This revision now requires changes to proceed.Jan 7 2020, 14:25
Fabien updated this revision to Diff 15193.Jan 7 2020, 15:36

Add a comment explaining the issue.

teamcity added a comment.Jan 7 2020, 15:36

Build Bitcoin-ABC / Diffs / Diff Testing started.

deadalnix accepted this revision.Jan 7 2020, 15:43
This revision is now accepted and ready to land.Jan 7 2020, 15:43
teamcity added a comment.Jan 7 2020, 15:52

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8762: Diff 15193.Jan 7 2020, 15:52
Closed by commit rABC1d0752d50148: [CI] Disable crypto assembly when building with ASAN (authored by Fabien). · Explain WhyJan 7 2020, 16:04
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC1d0752d50148: [CI] Disable crypto assembly when building with ASAN.
Fabien added a commit: rSTAGING1d0752d50148: [CI] Disable crypto assembly when building with ASAN.Apr 7 2020, 22:18

Revision Contents
Changeset List

PathSize
contrib/
teamcity/
4 lines

Diff 15193

View Options

contrib/teamcity/build-configurations.sh

Loading...