Page MenuHomePhabricator

[DEPENDS] Make the boost package build parallel
ClosedPublic

Authored by Fabien on Jan 8 2020, 16:05.

Details

Summary

The b2 boost build program runs with the available number of cores by
default (see the -j option
https://boostorg.github.io/build/manual/develop/index.html#bbv2.overview.invocation.options).
Passing it JOBS allow for the user to limit the number of core to be used if he wants to.

I didn't change the install -j4 parameter since I don't know where it
comes from, and I doubt it would make any difference since this step
will mostly copy files.

Test Plan
cd depends
make

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Jan 8 2020, 16:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 8 2020, 16:05
deadalnix requested changes to this revision.Jan 8 2020, 17:22

Why not pass the JOBS variable explicitly? If the person who want to run that script want a specific number of jobs, I think we should respect that and the default should work just fine.

This revision now requires changes to proceed.Jan 8 2020, 17:22
Fabien edited the summary of this revision. (Show Details)Jan 9 2020, 08:20
Fabien updated this revision to Diff 15258.Jan 9 2020, 08:22

Pass JOBS to allow the user to limit the number of core to be used.

deadalnix accepted this revision.Jan 9 2020, 11:29
This revision is now accepted and ready to land.Jan 9 2020, 11:29
This revision was automatically updated to reflect the committed changes.