[DEPENDS] Make the boost package build parallel
ClosedPublic
Actions

Authored by Fabien on Jan 8 2020, 16:05.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING8b0d1e05b8ed: [DEPENDS] Make the boost package build parallel
rABC8b0d1e05b8ed: [DEPENDS] Make the boost package build parallel

Summary

The b2 boost build program runs with the available number of cores by
default (see the -j option
https://boostorg.github.io/build/manual/develop/index.html#bbv2.overview.invocation.options).
Passing it JOBS allow for the user to limit the number of core to be used if he wants to.

I didn't change the install -j4 parameter since I don't know where it
comes from, and I doubt it would make any difference since this step
will mostly copy files.

Test Plan

cd depends
make

Diff Detail

Repository

rABC Bitcoin ABC

Branch

depends_boost_build_parallel

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8796
Build 15573: Default Diff Build & Tests
Build 15572: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 8 2020, 16:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 8 2020, 16:05

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8796: Diff 15237.Jan 8 2020, 16:09

Why not pass the JOBS variable explicitly? If the person who want to run that script want a specific number of jobs, I think we should respect that and the default should work just fine.

This revision now requires changes to proceed.Jan 8 2020, 17:22

Fabien edited the summary of this revision. (Show Details)Jan 9 2020, 08:20

Pass JOBS to allow the user to limit the number of core to be used.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8813: Diff 15258.Jan 9 2020, 08:42

deadalnix accepted this revision.Jan 9 2020, 11:29

This revision is now accepted and ready to land.Jan 9 2020, 11:29

Closed by commit rABC8b0d1e05b8ed: [DEPENDS] Make the boost package build parallel (authored by Fabien). · Explain WhyJan 9 2020, 14:12

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC8b0d1e05b8ed: [DEPENDS] Make the boost package build parallel.

Fabien added a commit: rSTAGING8b0d1e05b8ed: [DEPENDS] Make the boost package build parallel.Apr 7 2020, 22:20