Page MenuHomePhabricator

[bugfix] wallet: Fix duplicate fileid detection
ClosedPublic

Authored by Fabien on Jan 10 2020, 16:42.

Details

Summary
The implementation in current master can not detect if the file ID is
duplicate with flushed BerkeleyEnvironment. This PR would store the file
ID in a global variable g_fileids and release it when the
BerkeleyDatabase close. So it won't have to rely on a Db*.

Depends on D4884.

Backport of core PR14320:
https://github.com/bitcoin/bitcoin/pull/14320/files

Test Plan
ninja all check
./test/functional/test_runner.py wallet_*

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14320
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8833
Build 15641: Default Diff Build & Tests
Build 15640: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jan 10 2020, 17:45