bitcoin-abc
ClosedPublic
Actions

Authored by CCulianu on Aug 26 2017, 18:56.

Details

Reviewers

freetrader
deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING333cd5b0cf4d: fixed travis build warning/error related to rename of package from bitcoin ->…
rABC333cd5b0cf4d: fixed travis build warning/error related to rename of package from bitcoin ->…

Summary

Recent commit that fixed gitian builds to be 'bitcoin-abc' forgot to update travis.yml with new package name dir -- so the travis script was looking for a dir called build/bitcoin-$HOST when it should have been looking for build/bitcoin-abc-$HOST. Updated

Test Plan

Push this to github, enable travis builds, make sure building on travis works. In case you want to see the result of my build testing this fix, it's here:

https://travis-ci.org/cculianu/bitcoin-abc/builds/268733782?utm_source=github_status&utm_medium=notification

A failed job (before this change) is here:

https://travis-ci.org/cculianu/bitcoin-abc/jobs/268729320#L5154

Notice error on line 5154. Interestingly travis proceeds anyway but that red
error bothered me.

I locally use a travis-workalike set of scripts that I wrote so for me this
error to the .yml was fatal.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

CCulianu created this revision.Aug 26 2017, 18:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 26 2017, 18:56

Nice catch, accepting to get a second confirmation on the Travis result.
I think I need to look at why the errors related to the directory name didn't stop Travis.

freetrader accepted this revision.Aug 26 2017, 19:13

This revision is now accepted and ready to land.Aug 26 2017, 19:13

Closed by commit rABC333cd5b0cf4d: fixed travis build warning/error related to rename of package from bitcoin ->… (authored by CCulianu, committed by CCulianu). · Explain WhyAug 26 2017, 19:14

This revision was automatically updated to reflect the committed changes.