[CMAKE] Actually run the seeder tests
ClosedPublic
Actions

Authored by Fabien on Jan 10 2020, 21:57.

Details

Reviewers

deadalnix
nakihito

Group Reviewers

Restricted Project

Commits

rSTAGING7ef9e4ef302e: [CMAKE] Actually run the seeder tests
rABC7ef9e4ef302e: [CMAKE] Actually run the seeder tests

Summary

The seeder test executable is built, but no test is declared so they are
not run. This diff fixes this bug.

Test Plan

ninja check-bitcoin-seeder

Edit src/seeder/test/seeder_tests.cpp to make the test fail, then
re-run:

ninja check-bitcoin-seeder

Check the test failure is reported correctly.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 10 2020, 21:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 10 2020, 21:57

Herald added a reviewer: deadalnix. · View Herald Transcript

nakihito accepted this revision.Jan 10 2020, 21:59

This revision is now accepted and ready to land.Jan 10 2020, 21:59

This revision was landed with ongoing or failed builds.Jan 10 2020, 22:13

Closed by commit rABC7ef9e4ef302e: [CMAKE] Actually run the seeder tests (authored by Fabien). · Explain Why

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC7ef9e4ef302e: [CMAKE] Actually run the seeder tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8844: Diff 15318.Jan 10 2020, 22:28

Fabien added a commit: rSTAGING7ef9e4ef302e: [CMAKE] Actually run the seeder tests.Apr 7 2020, 22:22

Revision Contents
Changeset List

Path

Size

src/

seeder/

test/

CMakeLists.txt

3 lines

Diff 15319

View Options

src/seeder/test/CMakeLists.txt

[CMAKE] Actually run the seeder testsClosedPublicActions