Page MenuHomePhabricator
Differential D4900

parameterize ecmult_const over input size
ClosedPublic
Actions

Authored by deadalnix on Jan 11 2020, 13:39.

Details

Reviewers
markblundeberg
Group Reviewers
Restricted Project
Commits
rSTAGING95fb86547648: parameterize ecmult_const over input size
rABC95fb86547648: parameterize ecmult_const over input size
Summary

This is a backport of secp56k1's PR522

Test Plan
ninja check-secp256k1 bench-secp256k1

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Jan 11 2020, 13:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 11 2020, 13:39
teamcity added a comment.Jan 11 2020, 13:39

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 11 2020, 13:56

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8857: Diff 15336.Jan 11 2020, 13:57
markblundeberg requested changes to this revision.Jan 12 2020, 08:29
markblundeberg added a subscriber: markblundeberg.

link to PR please

This revision now requires changes to proceed.Jan 12 2020, 08:29
deadalnix requested review of this revision.Jan 12 2020, 14:03

https://github.com/bitcoin-core/secp256k1/pull/522

markblundeberg added a comment.Jan 13 2020, 14:13

Out of curiosity, why are we backporting these when Core doesn't have them in their master?

deadalnix added a comment.Jan 13 2020, 16:30
In D4900#118882, @markblundeberg wrote:

Out of curiosity, why are we backporting these when Core doesn't have them in their master?

I say why not :) We don't want to have a giant merge from hell at some point going forward.

markblundeberg accepted this revision.Jan 13 2020, 23:16

Never mind, I was wrong -- Core does have these changes.

This revision is now accepted and ready to land.Jan 13 2020, 23:16
Closed by commit rABC95fb86547648: parameterize ecmult_const over input size (authored by deadalnix). · Explain WhyJan 14 2020, 01:14
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC95fb86547648: parameterize ecmult_const over input size.
deadalnix added a commit: rSTAGING95fb86547648: parameterize ecmult_const over input size.Apr 7 2020, 22:25

Revision Contents
Changeset List

PathSize
src/
secp256k1/
src/
2 lines
4 lines
90 lines
3 lines
modules/
ecdh/
2 lines
24 lines
2 lines

Diff 15424

View Options

src/secp256k1/src/bench_internal.c

Loading...
View Options

src/secp256k1/src/ecmult_const.h

Loading...
View Options

src/secp256k1/src/ecmult_const_impl.h

Loading...
View Options

src/secp256k1/src/ecmult_impl.h

Loading...
View Options

src/secp256k1/src/modules/ecdh/main_impl.h

Loading...
View Options

src/secp256k1/src/tests.c

Loading...
View Options

src/secp256k1/src/tests_exhaustive.c

Loading...