Page MenuHomePhabricator

parameterize ecmult_const over input size
ClosedPublic

Authored by deadalnix on Jan 11 2020, 13:39.

Details

Summary

This is a backport of secp56k1's PR522

Test Plan
ninja check-secp256k1 bench-secp256k1

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Jan 11 2020, 13:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 11 2020, 13:39
markblundeberg requested changes to this revision.Jan 12 2020, 08:29
markblundeberg added a subscriber: markblundeberg.

link to PR please

This revision now requires changes to proceed.Jan 12 2020, 08:29

Out of curiosity, why are we backporting these when Core doesn't have them in their master?

Out of curiosity, why are we backporting these when Core doesn't have them in their master?

I say why not :) We don't want to have a giant merge from hell at some point going forward.

markblundeberg accepted this revision.Jan 13 2020, 23:16

Never mind, I was wrong -- Core does have these changes.

This revision is now accepted and ready to land.Jan 13 2020, 23:16
This revision was automatically updated to reflect the committed changes.