Page MenuHomePhabricator

[tests] remove test_bitcoin.h dependency on txmempool.h
ClosedPublic

Authored by markblundeberg on Mon, Jan 13, 14:01.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC5c92e06b6a0d: [tests] remove test_bitcoin.h dependency on txmempool.h
Summary

It turns out nothing was actually using the LockPoints field of the mempool
entry helper, and (looking to future) nothing in bitcoin Core's tests use
this field either. Getting rid of it lets us speed up test compilation/
recompilation by removing the (rather heavy) txmempool.h dependency and
its various indirect dependencies.

If it's needed again in future, it's easy enough to reintroduce.

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.