HomePhabricator

[tests] remove test_bitcoin.h dependency on txmempool.h

Description

[tests] remove test_bitcoin.h dependency on txmempool.h

Summary:
It turns out nothing was actually using the LockPoints field of the mempool
entry helper, and (looking to future) nothing in bitcoin Core's tests use
this field either. Getting rid of it lets us speed up test compilation/
recompilation by removing the (rather heavy) txmempool.h dependency and
its various indirect dependencies.

If it's needed again in future, it's easy enough to reintroduce.

Test Plan: ninja check

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D4923

Details

Provenance
Mark Lundeberg <markblundeberg@users.noreply.github.com>Authored on Jan 13 2020, 14:01
markblundebergPushed on Jan 13 2020, 15:04
Reviewer
Restricted Project
Differential Revision
D4923: [tests] remove test_bitcoin.h dependency on txmempool.h
Parents
rABCa383e5ddf95a: Fix -Wshadow warnings
Branches
Unknown
Tags
Unknown

Event Timeline