Page MenuHomePhabricator

[CI] Increase the coverage for the build-diff and build-master configs
ClosedPublic

Authored by Fabien on Jan 13 2020, 14:44.

Details

Summary

By using the more global targets check-all/check-extended and
check-upgrade-activated/check-upgrade-activated-extended, the
coverage is slightly increased (e.g. univalue and leveldb tests are
run). It also avoid maintenance burden as any new test will be run as
part of these global targets.
The build-check-all target can now be removed as there is no use case
for it anymore.

Depends on D4927.

Test Plan
ABC_BUILD_NAME=build-diff ./contrib/teamcity/build-configurations.sh
ABC_BUILD_NAME=build-master ./contrib/teamcity/build-configurations.sh

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Jan 13 2020, 14:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 13 2020, 14:44

Snippet of first build failure:

[14:44:40] :			 [Update checkout directory (/home/teamcity/buildAgent/work/c4a5708f2bae7929)] /usr/bin/git config lfs.storage /home/teamcity/buildAgent/system/git/git-48AA3180.git/lfs
[14:44:40] :			 [Update checkout directory (/home/teamcity/buildAgent/work/c4a5708f2bae7929)] /usr/bin/git config core.sparseCheckout true
[14:44:40] :			 [Update checkout directory (/home/teamcity/buildAgent/work/c4a5708f2bae7929)] /usr/bin/git config http.sslCAInfo
[14:44:40] :			 [Update checkout directory (/home/teamcity/buildAgent/work/c4a5708f2bae7929)] /usr/bin/git show-ref
[14:44:40] :			 [Update checkout directory (/home/teamcity/buildAgent/work/c4a5708f2bae7929)] /usr/bin/git show-ref refs/tags/phabricator/diff/15402
[14:44:40] :			 [Update checkout directory (/home/teamcity/buildAgent/work/c4a5708f2bae7929)] /usr/bin/git log -n1 --pretty=format:%H%x20%s 5770e6a4f2025bd57c1e459ba1415d2ce26f3fc5 --
[14:44:40] :			 [Update checkout directory (/home/teamcity/buildAgent/work/c4a5708f2bae7929)] /usr/bin/git -c credential.helper= checkout -q -f phabricator/diff/15402
[14:44:40] :			 [Update checkout directory (/home/teamcity/buildAgent/work/c4a5708f2bae7929)] /usr/bin/git show-ref refs/tags/phabricator/diff/15402
[14:44:41] :			 [Update checkout directory (/home/teamcity/buildAgent/work/c4a5708f2bae7929)] Cleaning Bitcoin ABC Staging in /home/teamcity/buildAgent/work/c4a5708f2bae7929 the file set ALL_UNTRACKED
[14:44:41] :			 [Update checkout directory (/home/teamcity/buildAgent/work/c4a5708f2bae7929)] /usr/bin/git clean -f -d -x
[14:44:41] : Build preparation done
[14:44:41]E: Step 1/1: Command Line
[14:44:41] :	 [Step 1/1] Ant JUnit report watcher
[14:44:41] :		 [Ant JUnit report watcher] Watching paths:
[14:44:41] :		 [Ant JUnit report watcher] +:build/test_bitcoin.xml
[14:44:41] :		 [Ant JUnit report watcher] +:test/functional/junit_results.xml
[14:44:41] :		 [Ant JUnit report watcher] +:build/junit_results*.xml
[14:44:41] :	 [Step 1/1] Starting: /home/teamcity/buildAgent/temp/agentTmp/custom_script7083595271962397595
[14:44:41] :	 [Step 1/1] in directory: /home/teamcity/buildAgent/work/c4a5708f2bae7929
[14:44:41] :	 [Step 1/1] Running build configuration 'build-default'...
[14:44:41]W:	 [Step 1/1] + : build-default
[14:44:41]W:	 [Step 1/1] + '[' -z build-default ']'
[14:44:41]W:	 [Step 1/1] + echo 'Running build configuration '\''build-default'\''...'
[14:44:41]W:	 [Step 1/1] ++ git rev-parse --show-toplevel
[14:44:41]W:	 [Step 1/1] + TOPLEVEL=/home/teamcity/buildAgent/work/c4a5708f2bae7929
[14:44:41]W:	 [Step 1/1] + export TOPLEVEL
[14:44:41]W:	 [Step 1/1] + trap print_sanitizers_log ERR
[14:44:41]W:	 [Step 1/1] +++ dirname ./contrib/teamcity/build-configurations.sh
[14:44:41]W:	 [Step 1/1] ++ cd ./contrib/teamcity
[14:44:41]W:	 [Step 1/1] ++ pwd
[14:44:41]W:	 [Step 1/1] + CI_SCRIPTS_DIR=/home/teamcity/buildAgent/work/c4a5708f2bae7929/contrib/teamcity
[14:44:41]W:	 [Step 1/1] + setup
[14:44:41]W:	 [Step 1/1] + : /home/teamcity/buildAgent/work/c4a5708f2bae7929/build
[14:44:41]W:	 [Step 1/1] ++ cd /home/teamcity/buildAgent/work/c4a5708f2bae7929/build
[14:44:41]W:	 [Step 1/1] ./contrib/teamcity/build-configurations.sh: line 20: cd: /home/teamcity/buildAgent/work/c4a5708f2bae7929/build: No such file or directory
[14:44:41]W:	 [Step 1/1] ++ pwd
[14:44:41]W:	 [Step 1/1] + BUILD_DIR=/home/teamcity/buildAgent/work/c4a5708f2bae7929
[14:44:41]W:	 [Step 1/1] + export BUILD_DIR
[14:44:41]W:	 [Step 1/1] + cd /home/teamcity/buildAgent/work/c4a5708f2bae7929
[14:44:41]W:	 [Step 1/1] ++ nproc
[14:44:41]W:	 [Step 1/1] + THREADS=12
[14:44:41]W:	 [Step 1/1] + export THREADS
[14:44:41]W:	 [Step 1/1] + SAN_SUPP_DIR=/home/teamcity/buildAgent/work/c4a5708f2bae7929/test/sanitizer_suppressions
[14:44:41]W:	 [Step 1/1] + SAN_LOG_DIR=/tmp/sanitizer_logs
[14:44:41]W:	 [Step 1/1] + mkdir -p /tmp/sanitizer_logs
[14:44:41]W:	 [Step 1/1] + rm -rf '/tmp/sanitizer_logs/*'
[14:44:41]W:	 [Step 1/1] + export ASAN_OPTIONS=malloc_context_size=0:log_path=/tmp/sanitizer_logs/asan.log
[14:44:41]W:	 [Step 1/1] + ASAN_OPTIONS=malloc_context_size=0:log_path=/tmp/sanitizer_logs/asan.log
[14:44:41]W:	 [Step 1/1] + export LSAN_OPTIONS=suppressions=/home/teamcity/buildAgent/work/c4a5708f2bae7929/test/sanitizer_suppressions/lsan:log_path=/tmp/sanitizer_logs/lsan.log
[14:44:41]W:	 [Step 1/1] + LSAN_OPTIONS=suppressions=/home/teamcity/buildAgent/work/c4a5708f2bae7929/test/sanitizer_suppressions/lsan:log_path=/tmp/sanitizer_logs/lsan.log
[14:44:41]W:	 [Step 1/1] + export TSAN_OPTIONS=suppressions=/home/teamcity/buildAgent/work/c4a5708f2bae7929/test/sanitizer_suppressions/tsan:log_path=/tmp/sanitizer_logs/tsan.log
[14:44:41]W:	 [Step 1/1] + TSAN_OPTIONS=suppressions=/home/teamcity/buildAgent/work/c4a5708f2bae7929/test/sanitizer_suppressions/tsan:log_path=/tmp/sanitizer_logs/tsan.log
[14:44:41] :	 [Step 1/1] Error: Invalid build name 'build-default'
[14:44:41]W:	 [Step 1/1] + export UBSAN_OPTIONS=suppressions=/home/teamcity/buildAgent/work/c4a5708f2bae7929/test/sanitizer_suppressions/ubsan:print_stacktrace=1:halt_on_error=1:log_path=/tmp/sanitizer_logs/ubsan.log
[14:44:41]W:	 [Step 1/1] + UBSAN_OPTIONS=suppressions=/home/teamcity/buildAgent/work/c4a5708f2bae7929/test/sanitizer_suppressions/ubsan:print_stacktrace=1:halt_on_error=1:log_path=/tmp/sanitizer_logs/ubsan.log
[14:44:41]W:	 [Step 1/1] + case "$ABC_BUILD_NAME" in
[14:44:41]W:	 [Step 1/1] + echo 'Error: Invalid build name '\''build-default'\'''
[14:44:41]W:	 [Step 1/1] + exit 2
[14:44:41]W:	 [Step 1/1] Process exited with code 2
[14:44:41]E:	 [Step 1/1] Process exited with code 2 (Step: Command Line)
deadalnix accepted this revision.Jan 14 2020, 01:14
This revision is now accepted and ready to land.Jan 14 2020, 01:14
Fabien updated this revision to Diff 15441.Jan 14 2020, 10:20

Rebase.