Page MenuHomePhabricator

Use __GNUC_PREREQ for detecting __builtin_expect
ClosedPublic

Authored by deadalnix on Jan 17 2020, 01:02.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCa071308f1954: Use __GNUC_PREREQ for detecting __builtin_expect
Summary

This is a backport of secp256k1's PR579

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Jan 17 2020, 01:02
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 17 2020, 01:02
Fabien added a subscriber: Fabien.Jan 17 2020, 10:09

I fail to see how this is an improvement, since that would prevent CLang from using __builtin_expect. Is this solving any issue ?

Fabien accepted this revision.Jan 17 2020, 15:40

Looking into it a bit more, a lot of features are already made GCC only with this macro, so let this move forward for the sake of keeping in sync.

This revision is now accepted and ready to land.Jan 17 2020, 15:40
This revision was automatically updated to reflect the committed changes.