Paths

Table of Contentst

Differential D4973

Use __GNUC_PREREQ for detecting __builtin_expect
ClosedPublic
Actions

Authored by deadalnix on Jan 17 2020, 01:02.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rSTAGINGa071308f1954: Use __GNUC_PREREQ for detecting __builtin_expect
rABCa071308f1954: Use __GNUC_PREREQ for detecting __builtin_expect

Summary

This is a backport of secp256k1's PR579

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

secppr579

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8995
Build 15952: Default Diff Build & Tests
Build 15951: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 17 2020, 01:02

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 17 2020, 01:02

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8995: Diff 15546.Jan 17 2020, 01:06

I fail to see how this is an improvement, since that would prevent CLang from using __builtin_expect. Is this solving any issue ?

Looking into it a bit more, a lot of features are already made GCC only with this macro, so let this move forward for the sake of keeping in sync.

This revision is now accepted and ready to land.Jan 17 2020, 15:40

Closed by commit rABCa071308f1954: Use __GNUC_PREREQ for detecting __builtin_expect (authored by Tim Ruffing <crypto@timruffing.de>, committed by deadalnix). · Explain WhyJan 17 2020, 15:44

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCa071308f1954: Use __GNUC_PREREQ for detecting __builtin_expect.

deadalnix added a commit: rSTAGINGa071308f1954: Use __GNUC_PREREQ for detecting __builtin_expect.Apr 7 2020, 22:31

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

configure.ac

6 lines

src/

util.h

2 lines

Diff 15546

View Options

src/secp256k1/configure.ac