Make constants static: static const secp256k1_ge secp256k1_ge_const_g; static const int CURVE_B;
ClosedPublic
Actions

Authored by deadalnix on Jan 17 2020, 01:32.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING0092109456d7: Make constants static: static const secp256k1_ge secp256k1_ge_const_g; static…
rABC0092109456d7: Make constants static: static const secp256k1_ge secp256k1_ge_const_g; static…

Summary

This is a backport of secp256k1's PR552

Test Plan

ninja check-secp256k1

Diff Detail

Repository

rABC Bitcoin ABC

Branch

secppr552

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8999
Build 15960: Default Diff Build & Tests
Build 15959: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 17 2020, 01:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 17 2020, 01:32

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8999: Diff 15550.Jan 17 2020, 01:36

Fabien accepted this revision.Jan 17 2020, 10:32

This revision is now accepted and ready to land.Jan 17 2020, 10:32

Closed by commit rABC0092109456d7: Make constants static: static const secp256k1_ge secp256k1_ge_const_g; static… (authored by Russell O'Connor <roconnor@blockstream.io>, committed by deadalnix). · Explain WhyJan 17 2020, 11:44

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC0092109456d7: Make constants static: static const secp256k1_ge secp256k1_ge_const_g; static….

deadalnix added a commit: rSTAGING0092109456d7: Make constants static: static const secp256k1_ge secp256k1_ge_const_g; static….Apr 7 2020, 22:30

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

src/

group_impl.h

10 lines

Diff 15550

View Options

src/secp256k1/src/group_impl.h

Make constants static: static const secp256k1_ge secp256k1_ge_const_g; static const int CURVE_B;ClosedPublicActions