Make use of TAG_PUBKEY constants in secp256k1_eckey_pubkey_parse
ClosedPublic
Actions

Authored by deadalnix on Jan 17 2020, 03:10.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING4cf7adeee08b: Make use of TAG_PUBKEY constants in secp256k1_eckey_pubkey_parse
rABC4cf7adeee08b: Make use of TAG_PUBKEY constants in secp256k1_eckey_pubkey_parse

Summary

This results in more self-documenting code.

This is a backport of secp256k1's PR562

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

secppr562

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9005
Build 15972: Default Diff Build & Tests
Build 15971: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 17 2020, 03:10

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 17 2020, 03:10

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9005: Diff 15556.Jan 17 2020, 03:15

Fabien accepted this revision.Jan 17 2020, 10:42

This revision is now accepted and ready to land.Jan 17 2020, 10:42

Closed by commit rABC4cf7adeee08b: Make use of TAG_PUBKEY constants in secp256k1_eckey_pubkey_parse (authored by Ben Woosley <ben.woosley@gmail.com>, committed by deadalnix). · Explain WhyJan 17 2020, 11:36

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC4cf7adeee08b: Make use of TAG_PUBKEY constants in secp256k1_eckey_pubkey_parse.

deadalnix added a commit: rSTAGING4cf7adeee08b: Make use of TAG_PUBKEY constants in secp256k1_eckey_pubkey_parse.Apr 7 2020, 22:29

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

src/

eckey_impl.h

2 lines

Diff 15556

View Options

src/secp256k1/src/eckey_impl.h

Make use of TAG_PUBKEY constants in secp256k1_eckey_pubkey_parseClosedPublicActions