Page MenuHomePhabricator

Switch x86_64 asm to use "i" instead of "n" for immediate values.
ClosedPublic

Authored by deadalnix on Jan 17 2020, 12:17.

Details

Summary

The constraint "n" is a more obscure setting which is needed for
special cases that don't apply to our use.

Use of "n" exposed some bugs in pre-release versions of clang.
This fixes #594

This is a backport of secp256k1's PR599

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Jan 17 2020, 12:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 17 2020, 12:18
Fabien accepted this revision.Jan 17 2020, 13:44
This revision is now accepted and ready to land.Jan 17 2020, 13:44
This revision was landed with ongoing or failed builds.Jan 17 2020, 14:19
This revision was automatically updated to reflect the committed changes.