HomePhabricator

Switch x86_64 asm to use "i" instead of "n" for immediate values.

Description

Switch x86_64 asm to use "i" instead of "n" for immediate values.

Summary:
The constraint "n" is a more obscure setting which is needed for
special cases that don't apply to our use.

Use of "n" exposed some bugs in pre-release versions of clang.
This fixes #594

This is a backport of secp256k1's PR599

Test Plan:

make check

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D4989

Details

Provenance
Gregory Maxwell <greg@xiph.org>Authored on Mar 10 2019, 22:52
deadalnixCommitted on Jan 17 2020, 14:18
deadalnixPushed on Jan 17 2020, 14:26
Reviewer
Restricted Project
Differential Revision
D4989: Switch x86_64 asm to use "i" instead of "n" for immediate values.
Parents
rSTAGING850100d894fa: Allow field_10x26_arm.s to compile for ARMv7 architecture
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/15595, tag: phabricator/base/15594, tag: phabricator/base/15593