Page MenuHomePhabricator
Differential D5002

[CMAKE] Get rid of `add_compiler_flags_to_var`
ClosedPublic
Actions

Authored by Fabien on Jan 17 2020, 16:02.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING98e3d4d14b82: [CMAKE] Get rid of `add_compiler_flags_to_var`
rABC98e3d4d14b82: [CMAKE] Get rid of `add_compiler_flags_to_var`
Summary

The last callsite is in the check_linker_flags function. Adding the
logic at the callsite allow to remove this function from the API.

There is no change in behavior.

Depends on D4961.

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 17 2020, 16:02
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 17 2020, 16:02
Herald added a reviewer: deadalnix. · View Herald Transcript
deadalnix requested changes to this revision.Jan 17 2020, 16:12
deadalnix added inline comments.
cmake/modules/AddCompilerFlags.cmake
115 ↗(On Diff #15602)

The flag not being supported should be a had fail.

This revision now requires changes to proceed.Jan 17 2020, 16:12
teamcity added a comment.Jan 17 2020, 16:25

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien requested review of this revision.Jan 17 2020, 16:27
Fabien added inline comments.
cmake/modules/AddCompilerFlags.cmake
115 ↗(On Diff #15602)

If there is no unused-command-line-argument warning (GCC) then there is no reason to promote it as an error. It's fine to continue in this case and not fail.

teamcity added a comment.Jan 17 2020, 16:40

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9027: Diff 15602.Jan 17 2020, 16:40
deadalnix accepted this revision.Jan 17 2020, 16:44
This revision is now accepted and ready to land.Jan 17 2020, 16:44
Closed by commit rABC98e3d4d14b82: [CMAKE] Get rid of `add_compiler_flags_to_var` (authored by Fabien). · Explain WhyJan 20 2020, 15:29
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC98e3d4d14b82: [CMAKE] Get rid of `add_compiler_flags_to_var`.
Fabien added a commit: rSTAGING98e3d4d14b82: [CMAKE] Get rid of `add_compiler_flags_to_var`.Apr 7 2020, 22:35

Revision Contents
Changeset List

PathSize
cmake/
modules/
24 lines

Diff 15689

View Options

cmake/modules/AddCompilerFlags.cmake

Loading...