Page MenuHomePhabricator

[CMAKE] Run wallet tests as part of the check-bitcoin target
ClosedPublic

Authored by Fabien on Jan 17 2020, 22:29.

Details

Summary

The wallet tests were build with the test_bitcoin executable but have
been forgotten as part of the check-bitcoin target.

Test Plan
ninja check-bitcoin

Ensure the wallet tests are run.

cmake -GNinja .. -DBUILD_BITCOIN_WALLET=OFF
ninja check-bitcoin

Ensure the tests are run, but no wallet test.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Jan 17 2020, 22:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 17 2020, 22:29
jasonbcox accepted this revision.Jan 17 2020, 22:32
jasonbcox added a subscriber: jasonbcox.

Beat me to it. For posterity, this was missed in D4698

This revision is now accepted and ready to land.Jan 17 2020, 22:32