Page MenuHomePhabricator
Differential D5011

Merge #14413: tests: Allow closed rpc handler in assert_start_raises_init_error
ClosedPublic
Actions

Authored by jasonbcox on Jan 18 2020, 00:51.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING302fe31a9e47: Merge #14413: tests: Allow closed rpc handler in assert_start_raises_init_error
rABC302fe31a9e47: Merge #14413: tests: Allow closed rpc handler in assert_start_raises_init_error
Summary

62c304ea48 tests: Allow closed http server in assert_start_raises_init_error (Chun Kuan Lee)

Pull request description:

The rpc handler may be unregistered when http server haven't been closed yet. So it may be allowable to get -342 `non-JSON HTTP response with \'%i %s\' from server` (503 Service Unavailable)

See https://ci.appveyor.com/project/DrahtBot/bitcoin/build/master.2001. It shows "Rejecting request while shutting down" between "RPC stopped" and "Stopped HTTP server"

Tree-SHA512: e1f50ab9096cf23494ccc2850c01516c4a75f112c99108759157b22fce2011682a4b88216f206702f6a56e960182c00098053ad75f13aa0eafe27046adae63da

Backport of Core PR14413
https://github.com/bitcoin/bitcoin/pull/14413/files

Test Plan
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr14413
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9041
Build 16044: Default Diff Build & Tests
Build 16043: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jan 18 2020, 00:51
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 18 2020, 00:51
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jan 18 2020, 00:51

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 18 2020, 00:56

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9041: Diff 15635.Jan 18 2020, 00:56
jasonbcox added a child revision: D5012: Merge #14494: Error if # is used in rpcpassword in conf.Jan 18 2020, 01:15
deadalnix accepted this revision.Jan 19 2020, 14:19
This revision is now accepted and ready to land.Jan 19 2020, 14:19
Closed by commit rABC302fe31a9e47: Merge #14413: tests: Allow closed rpc handler in assert_start_raises_init_error (authored by MarcoFalke <falke.marco@gmail.com>, committed by jasonbcox). · Explain WhyJan 19 2020, 19:20
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC302fe31a9e47: Merge #14413: tests: Allow closed rpc handler in assert_start_raises_init_error.
jasonbcox added a commit: rSTAGING302fe31a9e47: Merge #14413: tests: Allow closed rpc handler in assert_start_raises_init_error.Apr 7 2020, 22:35

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
4 lines

Diff 15635

View Options

test/functional/test_framework/test_node.py

Loading...