[cmake] Only set the native build marker once
ClosedPublic
Actions

Authored by deadalnix on Jan 18 2020, 17:48.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGfaf086373ffc: [cmake] Only set the native build marker once
rABCfaf086373ffc: [cmake] Only set the native build marker once

Summary

As it turns out, the second time it is set override the cache, which can create strange side effects.

Test Plan

Modify the cmake module in some trivial way.
Build with ninja, ensure that gen_context is not a problem anymore after regeneration.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jan 18 2020, 17:48

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 18 2020, 17:48

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9057: Diff 15655.Jan 18 2020, 17:53

jasonbcox accepted this revision.Jan 18 2020, 18:06

This revision is now accepted and ready to land.Jan 18 2020, 18:06

Closed by commit rABCfaf086373ffc: [cmake] Only set the native build marker once (authored by deadalnix). · Explain WhyJan 18 2020, 18:07

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCfaf086373ffc: [cmake] Only set the native build marker once.

deadalnix added a commit: rSTAGINGfaf086373ffc: [cmake] Only set the native build marker once.Apr 7 2020, 22:34

Revision Contents
Changeset List

Path

Size

cmake/

modules/

NativeExecutable.cmake

7 lines

Diff 15656

View Options

cmake/modules/NativeExecutable.cmake

[cmake] Only set the native build marker onceClosedPublicActions