Page MenuHomePhabricator
Differential D5024

Fix type mismatch for GetVirtualSizeWith<Descendants|Ancerstors>
ClosedPublic
Actions

Authored by Fabien on Jan 19 2020, 12:14.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING33f09e097bcc: Fix type mismatch for GetVirtualSizeWith<Descendants|Ancerstors>
rABC33f09e097bcc: Fix type mismatch for GetVirtualSizeWith<Descendants|Ancerstors>
Summary

These methods are declared to return an uint64_t but there definition
returns a size_t, which breaks the build on 32 bit platforms (and OSX
for some reason).

Test Plan
ninja check

Run the Gitian builds.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_type_mismatch
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9066
Build 16094: Default Diff Build & Tests
Build 16093: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 19 2020, 12:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 19 2020, 12:14
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jan 19 2020, 12:14

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 19 2020, 12:16

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Jan 19 2020, 12:18

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Jan 19 2020, 12:18

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9065: Diff 15667.Jan 19 2020, 12:18
teamcity added a comment.Jan 19 2020, 12:22

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing passed.

teamcity added a comment.Jan 19 2020, 12:22

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Jan 19 2020, 12:29

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing passed.

Fabien updated this revision to Diff 15668.Jan 19 2020, 12:29

Rebase.

teamcity added a comment.Jan 19 2020, 12:29

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 19 2020, 12:30

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing passed.

Fabien mentioned this in D5023: [CMAKE] Fix static linkage when building for Windows.Jan 19 2020, 12:30
teamcity added a comment.Jan 19 2020, 12:45

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9066: Diff 15668.Jan 19 2020, 12:45
deadalnix accepted this revision.Jan 19 2020, 13:58
This revision is now accepted and ready to land.Jan 19 2020, 13:58
Closed by commit rABC33f09e097bcc: Fix type mismatch for GetVirtualSizeWith<Descendants|Ancerstors> (authored by Fabien). · Explain WhyJan 19 2020, 14:05
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC33f09e097bcc: Fix type mismatch for GetVirtualSizeWith<Descendants|Ancerstors>.
Fabien added a commit: rSTAGING33f09e097bcc: Fix type mismatch for GetVirtualSizeWith<Descendants|Ancerstors>.Apr 7 2020, 22:34

Revision Contents
Changeset List

PathSize
src/
6 lines

Diff 15668

View Options

src/txmempool.cpp

Loading...