Page MenuHomePhabricator

Make WINDOW_G configurable
ClosedPublic

Authored by deadalnix on Jan 20 2020, 23:27.

Details

Summary
  • Make WINDOW_G configurable

This makes WINDOW_G a configurable value in the range of [2..24].
The upper limit of 24 is a defensive choice. The code is probably
correct for values up to 27 but those larger values yield in huge
tables (>= 256MiB), which are i) unlikely to be really beneficial
in practice and ii) increasingly difficult to test.

  • Clean up ./configure help strings

This is a backport of secp256k1 PR596

Test Plan
ninja check-secp256k1

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Jan 20 2020, 23:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 20 2020, 23:27
Fabien requested changes to this revision.Jan 21 2020, 15:29
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/secp256k1/configure.ac
143 ↗(On Diff #15694)

(default is yes) => [default=yes]

162 ↗(On Diff #15694)

You got some weird char here

409 ↗(On Diff #15694)

Nit: space after #

src/secp256k1/src/ecmult_impl.h
48 ↗(On Diff #15694)

Nit: not not

This revision now requires changes to proceed.Jan 21 2020, 15:29
deadalnix added inline comments.Jan 21 2020, 21:25
src/secp256k1/configure.ac
409 ↗(On Diff #15694)

I'd rather not change this, this is 100% vanilla.

deadalnix updated this revision to Diff 15727.Jan 21 2020, 21:37

Address comments

Fabien accepted this revision.Jan 22 2020, 04:51
Fabien added inline comments.
src/secp256k1/configure.ac
409 ↗(On Diff #15694)

Fair enough

This revision is now accepted and ready to land.Jan 22 2020, 04:51
This revision was automatically updated to reflect the committed changes.