Page MenuHomePhabricator

remove segwit recovery exemption from SCRIPT_VERIFY_INPUT_SIGCHECKS check
Needs RevisionPublic

Authored by markblundeberg on Jan 26 2020, 14:40.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Maniphest Tasks
T704: sigChecks implementation
Summary

This exemption isn't actually doing anything since P2SH scriptPubKeys have
no CHECK*SIG* opcodes, and scriptSigs have to be push-only. So this doesn't
currently change any behaviour, and it's simpler to think about in future
without having to consider exemption.

Depends on D5070

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
verifyscript_singlesuccess
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 9145
Build 16248: Bitcoin ABC Buildbot
Build 16247: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Jan 26 2020, 14:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 26 2020, 14:40
Fabien requested changes to this revision.Jan 30 2020, 10:03
Fabien added a subscriber: Fabien.

Clearing my queue for now since the changes requested for the parent D5070 will require updating this diff as well.

This revision now requires changes to proceed.Jan 30 2020, 10:03