Page MenuHomePhabricator
Differential D5104

Merge #13913: qa: Remove redundant checkmempool/checkblockindex extra_args
ClosedPublic
Actions

Authored by nakihito on Jan 29 2020, 20:57.

Details

Reviewers
markblundeberg
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING9788c101a9c0: Merge #13913: qa: Remove redundant checkmempool/checkblockindex extra_args
rABC9788c101a9c0: Merge #13913: qa: Remove redundant checkmempool/checkblockindex extra_args
Summary

fa31ca0c22 qa: Remove redundant checkmempool/checkblockindex extra_args (MarcoFalke)

Pull request description:

They are already enabled by default for regtest:

https://github.com/bitcoin/bitcoin/blob/df9f71274645a917e2578c52a1c59745bce8112d/src/init.cpp#L1002-L1007

Closes  #13912. CC #12138

Tree-SHA512: b11a3e8cc4715569f917ab89132f8c8dcae64aebcd7a34182675f86cf7f6e207e3187b7ea01a56c92c8c3af76122b6b995e84f533e134676863f8953dc1f0574

Backport of Core PR13913

Test Plan
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13913
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9193
Build 16333: Default Diff Build & Tests
Build 16332: arc lint + arc unit

Event Timeline

nakihito created this revision.Jan 29 2020, 20:57
Owners added a reviewer: Restricted Owners Package.Jan 29 2020, 20:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 29 2020, 20:57
teamcity edited the summary of this revision. (Show Details)Jan 29 2020, 20:57

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

teamcity added a comment.Jan 29 2020, 20:57

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito planned changes to this revision.Jan 29 2020, 21:00
teamcity added a comment.Jan 29 2020, 21:01

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9193: Diff 15882.Jan 29 2020, 21:02
nakihito requested review of this revision.Jan 29 2020, 21:02
markblundeberg accepted this revision.Jan 30 2020, 03:58
This revision is now accepted and ready to land.Jan 30 2020, 03:58
Closed by commit rABC9788c101a9c0: Merge #13913: qa: Remove redundant checkmempool/checkblockindex extra_args (authored by MarcoFalke <falke.marco@gmail.com>, committed by nakihito). · Explain WhyJan 30 2020, 19:12
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC9788c101a9c0: Merge #13913: qa: Remove redundant checkmempool/checkblockindex extra_args.
nakihito added a commit: rSTAGING9788c101a9c0: Merge #13913: qa: Remove redundant checkmempool/checkblockindex extra_args.Apr 7 2020, 22:43

Revision Contents
Changeset List

Diff 15882

View Options

test/functional/feature_reindex.py

Loading...
View Options

test/functional/mempool_accept.py

Loading...
View Options

test/functional/mempool_reorg.py

Loading...
View Options

test/functional/mempool_resurrect.py

Loading...
View Options

test/functional/mempool_spend_coinbase.py

Loading...