Page MenuHomePhabricator
Differential D5105

Merge #13948: trivial: Removes unsed `CBloomFilter` constructor.
ClosedPublic
Actions

Authored by nakihito on Jan 30 2020, 00:59.

Details

Reviewers
markblundeberg
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGc6c583bedc22: Merge #13948: trivial: Removes unsed `CBloomFilter` constructor.
rABCc6c583bedc22: Merge #13948: trivial: Removes unsed `CBloomFilter` constructor.
Summary

265bd50884ac1984c08f0e5916256d5f12e655f5 Removes unsed CBloomFilter constructor. (251)

Pull request description:

This pull request removes the `CBloomFilter::CBloomFilter(const unsigned int, const double, const unsigned int)` constructor, which became obsolete with 086ee67.

Tree-SHA512: 46742f178e219661e82609a9bf6b644ebc58ab3efc2d1865c5562980e84f16a5fa286be9813738196ad7a27e639dee926062538eb44cadd67ab87ad5e9a266ba

Backport of Core PR13948

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Jan 30 2020, 00:59
Owners added a reviewer: Restricted Owners Package.Jan 30 2020, 00:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 30 2020, 00:59
teamcity edited the summary of this revision. (Show Details)Jan 30 2020, 00:59

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

teamcity added a comment.Jan 30 2020, 00:59

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 30 2020, 01:04

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9194: Diff 15883.Jan 30 2020, 01:04
markblundeberg requested changes to this revision.Jan 30 2020, 03:56
markblundeberg added a subscriber: markblundeberg.

linked to wrong PR # (transposed digits)

This revision now requires changes to proceed.Jan 30 2020, 03:56
nakihito requested review of this revision.Jan 30 2020, 04:18
nakihito edited the summary of this revision. (Show Details)
markblundeberg accepted this revision.Jan 30 2020, 08:13
This revision is now accepted and ready to land.Jan 30 2020, 08:13
Closed by commit rABCc6c583bedc22: Merge #13948: trivial: Removes unsed `CBloomFilter` constructor. (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyJan 30 2020, 19:06
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABCc6c583bedc22: Merge #13948: trivial: Removes unsed `CBloomFilter` constructor..
nakihito added a commit: rSTAGINGc6c583bedc22: Merge #13948: trivial: Removes unsed `CBloomFilter` constructor..Apr 7 2020, 22:43

Revision Contents
Changeset List

PathSize
src/
5 lines
8 lines

Diff 15889

View Options

src/bloom.h

Loading...
View Options

src/bloom.cpp

Loading...