Page MenuHomePhabricator
Differential D5111

Merge #13967: [walletdb] don't report minversion wallet entry as unknown
ClosedPublic
Actions

Authored by nakihito on Jan 30 2020, 21:04.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING0ee48883f58d: Merge #13967: [walletdb] don't report minversion wallet entry as unknown
rABC0ee48883f58d: Merge #13967: [walletdb] don't report minversion wallet entry as unknown
Summary

321159e53e800c1df2d8dfd6ac03374f1829c327 don't report minversion wallet entry as unknown (Gregory Sanders)

Pull request description:

It is known in WalletBatch::LoadWallet

Tree-SHA512: 82f7e12f48ae7d17317074ce5b5e27c70ba8334b04adbf7cc863f8169cc1aa460b9454571e2698aa00059c8c8f669fe19c0d40c4910dcded260ddca6ce78be9d

Backport of Core PR13967

Test Plan
make check
test_runner.py wallet_*

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13967
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9202
Build 16350: Default Diff Build & Tests
Build 16349: arc lint + arc unit

Event Timeline

nakihito created this revision.Jan 30 2020, 21:04
Owners added a reviewer: Restricted Owners Package.Jan 30 2020, 21:04
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 30 2020, 21:04
teamcity edited the summary of this revision. (Show Details)Jan 30 2020, 21:05

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

teamcity added a comment.Jan 30 2020, 21:05

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 30 2020, 21:10

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9202: Diff 15897.Jan 30 2020, 21:10
Fabien accepted this revision.Jan 30 2020, 22:55
This revision is now accepted and ready to land.Jan 30 2020, 22:55
Closed by commit rABC0ee48883f58d: Merge #13967: [walletdb] don't report minversion wallet entry as unknown (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyJan 31 2020, 01:32
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC0ee48883f58d: Merge #13967: [walletdb] don't report minversion wallet entry as unknown.
nakihito added a commit: rSTAGING0ee48883f58d: Merge #13967: [walletdb] don't report minversion wallet entry as unknown.Apr 7 2020, 22:44

Revision Contents
Changeset List

PathSize
src/
wallet/
3 lines

Diff 15897

View Options

src/wallet/walletdb.cpp

Loading...