[CMAKE] Make Qt protobuf an object library
ClosedPublic
Actions

Authored by Fabien on Jan 31 2020, 14:13.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING4927f0605c0b: [CMAKE] Make Qt protobuf an object library
rABC4927f0605c0b: [CMAKE] Make Qt protobuf an object library

Summary

That will allow for setting properties on these generated files that do
not apply to other Qt targets. This will be useful for preventing
clang-tidy from running on the generated files.

There is no change in behavior.

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 31 2020, 14:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 31 2020, 14:13

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien mentioned this in D5119: Automatically add missing braces.Jan 31 2020, 14:17

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9217: Diff 15925.Jan 31 2020, 14:19

Fabien added a child revision: D5119: Automatically add missing braces.Jan 31 2020, 14:19

deadalnix accepted this revision.Jan 31 2020, 15:22

This revision is now accepted and ready to land.Jan 31 2020, 15:22

Closed by commit rABC4927f0605c0b: [CMAKE] Make Qt protobuf an object library (authored by Fabien). · Explain WhyJan 31 2020, 17:24

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC4927f0605c0b: [CMAKE] Make Qt protobuf an object library.

Fabien removed a child revision: D5119: Automatically add missing braces.Feb 3 2020, 12:54

Fabien added a commit: rSTAGING4927f0605c0b: [CMAKE] Make Qt protobuf an object library.Apr 7 2020, 22:45

Revision Contents
Changeset List

Path

Size

src/

qt/

CMakeLists.txt

13 lines

Diff 15930

View Options

[CMAKE] Make Qt protobuf an object libraryClosedPublicActions