Page MenuHomePhabricator
Differential D5152

Increase timeout in avalanche test
ClosedPublic
Actions

Authored by Fabien on Feb 4 2020, 13:56.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGa325a27e7eb9: Increase timeout in avalanche test
rABCa325a27e7eb9: Increase timeout in avalanche test
Summary

When running with TSAN the query can be delayed so much that the timeout
is not enough.
Bumping the timeout by an order of magnitude should prevent the CI
failure without slowing the test in the average case.

Test Plan

Run the CI build-tsan build configuration.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_tests_increase_timeout
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9260
Build 16462: Default Diff Build & Tests
Build 16461: arc lint + arc unit

Event Timeline

Fabien created this revision.Feb 4 2020, 13:56
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 4 2020, 13:56
teamcity added a comment.Feb 4 2020, 13:56

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 4 2020, 14:01

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9260: Diff 15998.Feb 4 2020, 14:01
teamcity added a comment.Feb 4 2020, 14:05

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing started.

teamcity added a comment.Feb 4 2020, 14:14

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing passed.

deadalnix accepted this revision.Feb 4 2020, 15:02
This revision is now accepted and ready to land.Feb 4 2020, 15:02
deadalnix added inline comments.Feb 4 2020, 15:04
src/test/avalanche_tests.cpp
890

Because i is not used in the loop, it is probably better to use a time limit here rather than a count.

Closed by commit rABCa325a27e7eb9: Increase timeout in avalanche test (authored by Fabien). · Explain WhyFeb 4 2020, 15:10
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCa325a27e7eb9: Increase timeout in avalanche test.
Fabien added a commit: rSTAGINGa325a27e7eb9: Increase timeout in avalanche test.Apr 7 2020, 22:48

Revision Contents
Changeset List

PathSize
src/
test/
2 lines

Diff 15998

View Options

src/test/avalanche_tests.cpp

Loading...