Page MenuHomePhabricator

Disable clang-tidy by default
ClosedPublic

Authored by deadalnix on Feb 5 2020, 17:40.

Details

Summary

While this doesn't slow down a fresh build by much, this is disastrous when jumping between branches as none of the results are cached and they all need to be recomputed.

Test Plan

Run ninja clean and then ninja with clang-tidy:

real    1m22.667s
user    11m38.143s
sys     0m37.996s

Now the same without clang-tidy:

real    0m28.937s
user    0m46.723s
sys     0m10.769s

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Yeah I get the same kind of timings and as you say, jumping branches gets to be a headache... I caved in finally and turned off the option locally.

Fabien added a subscriber: Fabien.

I spent a lot of time trying to tweak ccache to make it understand clang-tidy as a compiler command but so far nothing worked.
This is reasonable to disable it by default for now.

This revision is now accepted and ready to land.Feb 5 2020, 17:53
This revision was automatically updated to reflect the committed changes.