Differential D5164

Remove redundant std::move
ClosedPublic
Actions

Authored by deadalnix on Feb 5 2020, 17:50.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rSTAGINGadcba09b85d2: Remove redundant std::move
rABCadcba09b85d2: Remove redundant std::move

Summary

I don't think the comment concerns any of the compiler we are concerned about.

Test Plan

make check

Verify the warning is gone.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

redundantmove

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9280
Build 16501: Default Diff Build & Tests
Build 16500: arc lint + arc unit

Event Timeline

deadalnix created this revision.Feb 5 2020, 17:50

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 5 2020, 17:50

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien accepted this revision.Feb 5 2020, 17:54

This revision is now accepted and ready to land.Feb 5 2020, 17:54

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9280: Diff 16036.Feb 5 2020, 17:55

Closed by commit rABCadcba09b85d2: Remove redundant std::move (authored by deadalnix). · Explain WhyFeb 5 2020, 19:02

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCadcba09b85d2: Remove redundant std::move.

deadalnix added a commit: rSTAGINGadcba09b85d2: Remove redundant std::move.Apr 7 2020, 22:49

Revision Contents
Changeset List

Path

Size

src/

interfaces/

chain.cpp

4 lines

Diff 16036

View Options

Remove redundant std::moveClosedPublicActions