Page MenuHomePhabricator

Merge #14993: rpc: Fix data race (UB) in InterruptRPC()
ClosedPublic

Authored by markblundeberg on Thu, Feb 6, 09:37.

Details

Summary

Backport PR14993 . Fixes T733 .

6c10037f72073eecc674c313580ef50a4f1e1e44 rpc: Fix data race (UB) in InterruptRPC() (practicalswift)

Pull request description:

Fix data race (UB) in `InterruptRPC()`.

Before:

```
$ ./configure --with-sanitizers=thread
$ make
$ test/functional/test_runner.py feature_shutdown.py
…
SUMMARY: ThreadSanitizer: data race rpc/server.cpp:314 in InterruptRPC()
…
ALL                 | ✖ Failed  | 2 s (accumulated)
```

After:

```
$ ./configure --with-sanitizers=thread
$ make
$ test/functional/test_runner.py feature_shutdown.py
…
ALL                 | ✓ Passed  | 3 s (accumulated)
```
Test Plan

ninja check-all ; run tests with TSAN

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markblundeberg created this revision.Thu, Feb 6, 09:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Feb 6, 09:37
teamcity edited the summary of this revision. (Show Details)Thu, Feb 6, 09:37

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

Fabien accepted this revision.Thu, Feb 6, 09:57
This revision is now accepted and ready to land.Thu, Feb 6, 09:57