Page MenuHomePhabricator
Differential D5177

Merge #14993: rpc: Fix data race (UB) in InterruptRPC()
ClosedPublic
Actions

Authored by markblundeberg on Feb 6 2020, 09:37.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Maniphest Tasks
T733: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Master TSAN is broken.
Commits
rSTAGINGcf4fb07ca99d: Merge #14993: rpc: Fix data race (UB) in InterruptRPC()
rABCcf4fb07ca99d: Merge #14993: rpc: Fix data race (UB) in InterruptRPC()
Summary

Backport PR14993 . Fixes T733 .

6c10037f72073eecc674c313580ef50a4f1e1e44 rpc: Fix data race (UB) in InterruptRPC() (practicalswift)

Pull request description:

Fix data race (UB) in `InterruptRPC()`.

Before:

```
$ ./configure --with-sanitizers=thread
$ make
$ test/functional/test_runner.py feature_shutdown.py
…
SUMMARY: ThreadSanitizer: data race rpc/server.cpp:314 in InterruptRPC()
…
ALL                 | ✖ Failed  | 2 s (accumulated)
```

After:

```
$ ./configure --with-sanitizers=thread
$ make
$ test/functional/test_runner.py feature_shutdown.py
…
ALL                 | ✓ Passed  | 3 s (accumulated)
```
Test Plan

ninja check-all ; run tests with TSAN

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr14993
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9296
Build 16529: Default Diff Build & Tests
Build 16528: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Feb 6 2020, 09:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 6 2020, 09:37
teamcity edited the summary of this revision. (Show Details)Feb 6 2020, 09:37

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

markblundeberg edited the summary of this revision. (Show Details)Feb 6 2020, 09:40
markblundeberg added a task: T733: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Master TSAN is broken..
teamcity added a comment.Feb 6 2020, 09:46

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing started.

teamcity added a comment.Feb 6 2020, 09:47

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 6 2020, 09:55

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing passed.

Fabien accepted this revision.Feb 6 2020, 09:57
This revision is now accepted and ready to land.Feb 6 2020, 09:57
This revision was landed with ongoing or failed builds.Feb 6 2020, 10:03
Closed by commit rABCcf4fb07ca99d: Merge #14993: rpc: Fix data race (UB) in InterruptRPC() (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by Mark Lundeberg <markblundeberg@users.noreply.github.com>). · Explain Why
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rABCcf4fb07ca99d: Merge #14993: rpc: Fix data race (UB) in InterruptRPC().
markblundeberg mentioned this in D5170: Merge #14670: http: Fix HTTP server shutdown.Feb 6 2020, 10:04
teamcity added a comment.Feb 6 2020, 10:06

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9296: Diff 16068.Feb 6 2020, 10:06
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rSTAGINGcf4fb07ca99d: Merge #14993: rpc: Fix data race (UB) in InterruptRPC().Apr 7 2020, 22:50

Revision Contents
Changeset List

PathSize
src/
rpc/
8 lines

Diff 16068

View Options

src/rpc/server.cpp

Loading...