Page MenuHomePhabricator

Merge #13823: qa: quote path in authproxy for external multiwallets
ClosedPublic

Authored by nakihito on Fri, Feb 7, 01:15.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCc7af8f0ab549: Merge #13823: qa: quote path in authproxy for external multiwallets
Summary

fa67505e1ea007bdc081bc7425fb83d5455d8308 qa: Quote wallet name for rpc path (MarcoFalke)

Pull request description:

When using external multiwallets they are specified by their full path which might contain non-ascii characters (e.g. umlauts or emojis).

Fix this by url-quoting the path.

Tree-SHA512: 7cc66514579d9f602f88a6817c5ab43a44c6d3711df452dc904173f0bc34e2c0b2c34877497f06b61f6720c532fa183053f54622dc454e316c89cee7eaa72463

Backport of Core PR13823

Test Plan
test_runner.py wallet*

In wallet_multiwallet.py change instances of w8 to

test_runner.py wallet_multiwallet.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Fri, Feb 7, 01:15
Owners added a reviewer: Restricted Owners Package.Fri, Feb 7, 01:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Feb 7, 01:15
nakihito planned changes to this revision.Fri, Feb 7, 01:15
teamcity edited the summary of this revision. (Show Details)Fri, Feb 7, 01:15

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

nakihito requested review of this revision.Fri, Feb 7, 01:16
jasonbcox accepted this revision.Fri, Feb 7, 02:15
This revision is now accepted and ready to land.Fri, Feb 7, 02:15