Page MenuHomePhabricator
Differential D5187

Merge #13823: qa: quote path in authproxy for external multiwallets
ClosedPublic
Actions

Authored by nakihito on Feb 7 2020, 01:15.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGc7af8f0ab549: Merge #13823: qa: quote path in authproxy for external multiwallets
rABCc7af8f0ab549: Merge #13823: qa: quote path in authproxy for external multiwallets
Summary

fa67505e1ea007bdc081bc7425fb83d5455d8308 qa: Quote wallet name for rpc path (MarcoFalke)

Pull request description:

When using external multiwallets they are specified by their full path which might contain non-ascii characters (e.g. umlauts or emojis).

Fix this by url-quoting the path.

Tree-SHA512: 7cc66514579d9f602f88a6817c5ab43a44c6d3711df452dc904173f0bc34e2c0b2c34877497f06b61f6720c532fa183053f54622dc454e316c89cee7eaa72463

Backport of Core PR13823

Test Plan
test_runner.py wallet*

In wallet_multiwallet.py change instances of w8 to ₿

test_runner.py wallet_multiwallet.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13823
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9312
Build 16560: Default Diff Build & Tests
Build 16559: arc lint + arc unit

Event Timeline

nakihito created this revision.Feb 7 2020, 01:15
Owners added a reviewer: Restricted Owners Package.Feb 7 2020, 01:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 7 2020, 01:15
nakihito planned changes to this revision.Feb 7 2020, 01:15
teamcity added a comment.Feb 7 2020, 01:15

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity edited the summary of this revision. (Show Details)Feb 7 2020, 01:15

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

nakihito requested review of this revision.Feb 7 2020, 01:16
teamcity added a comment.Feb 7 2020, 01:20

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9312: Diff 16090.Feb 7 2020, 01:20
jasonbcox accepted this revision.Feb 7 2020, 02:15
This revision is now accepted and ready to land.Feb 7 2020, 02:15
Closed by commit rABCc7af8f0ab549: Merge #13823: qa: quote path in authproxy for external multiwallets (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyFeb 7 2020, 18:35
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABCc7af8f0ab549: Merge #13823: qa: quote path in authproxy for external multiwallets.
nakihito added a commit: rSTAGINGc7af8f0ab549: Merge #13823: qa: quote path in authproxy for external multiwallets.Apr 7 2020, 22:54

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
3 lines

Diff 16090

View Options

test/functional/test_framework/test_node.py

Loading...