Cache the result of chainparams.GetConsensus() in miner code
ClosedPublic
Actions

Authored by deadalnix on Feb 9 2020, 23:26.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING8e591f10ec22: Cache the result of chainparams.GetConsensus() in miner code
rABC8e591f10ec22: Cache the result of chainparams.GetConsensus() in miner code

Summary

Calling the same function again and again is redudant.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

minerconsensus

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9375
Build 16681: Default Diff Build & Tests
Build 16680: arc lint + arc unit

Event Timeline

deadalnix created this revision.Feb 9 2020, 23:26

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 9 2020, 23:26

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9375: Diff 16196.Feb 9 2020, 23:35

Fabien accepted this revision.Feb 10 2020, 08:37

This revision is now accepted and ready to land.Feb 10 2020, 08:37

Closed by commit rABC8e591f10ec22: Cache the result of chainparams.GetConsensus() in miner code (authored by deadalnix). · Explain WhyFeb 10 2020, 13:05

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC8e591f10ec22: Cache the result of chainparams.GetConsensus() in miner code.

deadalnix added a commit: rSTAGING8e591f10ec22: Cache the result of chainparams.GetConsensus() in miner code.Apr 7 2020, 22:55

Revision Contents
Changeset List

Path

Size

src/

miner.cpp

14 lines

Diff 16196

View Options

Cache the result of chainparams.GetConsensus() in miner codeClosedPublicActions