Differential D5255

Fix nits in RPC help messages
ClosedPublic
Actions

Authored by Fabien on Feb 11 2020, 10:40.

Details

Reviewers

markblundeberg

Group Reviewers

Restricted Project

Commits

rSTAGING7f6d7071b816: Fix nits in RPC help messages
rABC7f6d7071b816: Fix nits in RPC help messages

Summary

Fix some nits found while reviewing D5239.

Test Plan

ninja all check

./src/bitcoind -daemon
./src/bitcoin-cli help signrawtransactionwithkey
./src/bitcoin-cli help listunspent
./src/bitcoin-cli help signrawtransactionwithwallet
./src/bitcoin-cli help walletcreatefundedpsbt

Make sure the help is correct.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_rpc_help

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9423
Build 16775: Default Diff Build & Tests
Build 16774: arc lint + arc unit

Event Timeline

Fabien created this revision.Feb 11 2020, 10:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 11 2020, 10:40

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9423: Diff 16263.Feb 11 2020, 10:49

markblundeberg accepted this revision.Feb 11 2020, 11:03

This revision is now accepted and ready to land.Feb 11 2020, 11:03

Closed by commit rABC7f6d7071b816: Fix nits in RPC help messages (authored by Fabien). · Explain WhyFeb 11 2020, 11:15

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC7f6d7071b816: Fix nits in RPC help messages.

Fabien added a commit: rSTAGING7f6d7071b816: Fix nits in RPC help messages.Apr 7 2020, 22:57

Revision Contents
Changeset List

Path

Size

src/

rpc/

rawtransaction.cpp

2 lines

wallet/

rpcwallet.cpp

10 lines

Diff 16263

View Options

src/rpc/rawtransaction.cpp