Page MenuHomePhabricator
Differential D5257

RPCHelpMan fixups
ClosedPublic
Actions

Authored by markblundeberg on Feb 11 2020, 11:46.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING43da31c7d549: RPCHelpMan fixups
rABC43da31c7d549: RPCHelpMan fixups
Summary

Split off from D5239, the original got several things wrong.

Depends on D5239

Test Plan

ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr14530
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9429
Build 16787: Default Diff Build & Tests
Build 16786: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Feb 11 2020, 11:46
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 11 2020, 11:46
teamcity added a comment.Feb 11 2020, 11:46

Build Bitcoin-ABC / Diffs / Diff Testing started.

markblundeberg mentioned this in D5239: Merge #14530: Use RPCHelpMan to generate RPC doc strings.Feb 11 2020, 11:50
teamcity added a comment.Feb 11 2020, 12:07

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9429: Diff 16270.Feb 11 2020, 12:07
Fabien accepted this revision.Feb 11 2020, 12:50
Fabien added inline comments.
src/wallet/rpcwallet.cpp
4047

Note: this is part of PR14726: https://github.com/bitcoin/bitcoin/pull/14726/files#diff-df7d84ff2f53fcb2a0dc15a3a51e55ceR2823

This revision is now accepted and ready to land.Feb 11 2020, 12:50
Closed by commit rABC43da31c7d549: RPCHelpMan fixups (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>). · Explain WhyFeb 11 2020, 14:03
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rABC43da31c7d549: RPCHelpMan fixups.
markblundeberg added inline comments.Feb 11 2020, 14:08
src/rpc/rawtransaction.cpp
1040

"privkyes" heh

Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rSTAGING43da31c7d549: RPCHelpMan fixups.Apr 7 2020, 22:57

Revision Contents
Changeset List

PathSize
src/
rpc/
2 lines
wallet/
8 lines

Diff 16270

View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...