Page MenuHomePhabricator
Differential D5295

Merge #14307: Consolidate redundant implementations of ParseHashStr
ClosedPublic
Actions

Authored by nakihito on Feb 15 2020, 00:30.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGe3f2849c16f4: Merge #14307: Consolidate redundant implementations of ParseHashStr
rABCe3f2849c16f4: Merge #14307: Consolidate redundant implementations of ParseHashStr
Summary

9c5af58d51 Consolidate redundant implementations of ParseHashStr (Ben Woosley)

Pull request description:

This change:
* adds a length check to all calls to `ParseHashStr`, appropriate given its use to populate
  a 256-bit number from a hex str
* allows the caller to handle the failure, which allows for the more
  appropriate `JSONRPCError` on failure in `prioritisetransaction` rpc

Relative to #14288

Tree-SHA512: baa791147e5ceb3c30c70df3981aaf807bf7d4a90a0be3625540b59aa4b9a9d303a452bfef18bf167cbb833ef9591b4ef5948bf4a1ce67b421d804ae8d20ea53

Backport of Core PR14307
https://github.com/bitcoin/bitcoin/pull/14307/

Depends on D5294

Test Plan
ninja check
ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14307
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9508
Build 16928: Default Diff Build & Tests
Build 16927: arc lint + arc unit

Event Timeline

nakihito created this revision.Feb 15 2020, 00:30
Owners added a reviewer: Restricted Owners Package.Feb 15 2020, 00:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 15 2020, 00:30
teamcity edited the summary of this revision. (Show Details)Feb 15 2020, 00:30

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

teamcity added a comment.Feb 15 2020, 00:30

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 15 2020, 00:40

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9508: Diff 16398.Feb 15 2020, 00:40
Fabien accepted this revision.Feb 17 2020, 12:05
This revision is now accepted and ready to land.Feb 17 2020, 12:05
Closed by commit rABCe3f2849c16f4: Merge #14307: Consolidate redundant implementations of ParseHashStr (authored by MarcoFalke <falke.marco@gmail.com>, committed by nakihito). · Explain WhyFeb 18 2020, 22:49
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABCe3f2849c16f4: Merge #14307: Consolidate redundant implementations of ParseHashStr.
nakihito added a commit: rSTAGINGe3f2849c16f4: Merge #14307: Consolidate redundant implementations of ParseHashStr.Apr 7 2020, 23:03

Revision Contents
Changeset List

PathSize
src/
14 lines
11 lines
11 lines
9 lines
test/
13 lines
test/
util/
data/
60 lines

Diff 16398

View Options

src/bitcoin-tx.cpp

Loading...
View Options

src/core_io.h

Loading...
View Options

src/core_read.cpp

Loading...
View Options

src/rest.cpp

Loading...
View Options

src/test/blockfilter_tests.cpp

Loading...
View Options

test/util/data/bitcoin-util-test.json

Loading...